Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove blob sign/verify related contents #1011

Merged
merged 11 commits into from
Aug 16, 2024
Merged

refactor!: remove blob sign/verify related contents #1011

merged 11 commits into from
Aug 16, 2024

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Aug 15, 2024 •
edited
Loading

As discussed, this PR removes the blob sign/verify related contents for v1.2.0 release.

This PR targets on branch release-1.2 ONLY.

@Two-Hearts
removed blob sign/verify for release
dbc214d 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
updating dependencies
7029be3 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
updated notation-go for v1.2.0 release
e1df4b7 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fixed E2E tests
c609608 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
updated for v1.2.0 release
c5df1b9 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
updated noation-go for v1.2.0 release
c9a2b37 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts changed the base branch from main to release-1.2 August 15, 2024 03:24
@codecov Codecov
Copy link

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.01%. Comparing base (767d1e3) to head (5129af1).
Report is 1 commits behind head on release-1.2.

Additional details and impacted files 
@@             Coverage Diff              @@
##           release-1.2    #1011   +/-   ##
============================================
  Coverage        72.01%   72.01%           
============================================
  Files               46       46           
  Lines             2287     2287           
============================================
  Hits              1647     1647           
  Misses             440      440           
  Partials           200      200

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Two-Hearts
updated notation-go
80485ea 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fixed E2E tests
f07a40a 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts requested a review from JeyJeyGao August 15, 2024 06:49
@Two-Hearts
updated for v1.2.0 release
c415dc7 
Signed-off-by: Patrick Zheng <[email protected]>
JeyJeyGao
JeyJeyGao reviewed Aug 15, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pending on dependencies.

shizhMSFT
shizhMSFT reviewed Aug 15, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-reviewed with

go.mod Outdated Show resolved Hide resolved
test/e2e/plugin/go.mod Outdated Show resolved Hide resolved
specs/commandline/inspect.md Show resolved Hide resolved
specs/commandline/policy.md Show resolved Hide resolved
specs/commandline/sign.md Show resolved Hide resolved
specs/commandline/verify.md Show resolved Hide resolved
specs/notation-cli.md Show resolved Hide resolved
specs/commandline/verify.md Show resolved Hide resolved
@Two-Hearts
updated for v1.2.0 release
6e692c7 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts mentioned this pull request Aug 16, 2024
Closed
@Two-Hearts
updated for v1.2.0 release
5129af1 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 7933156 into notaryproject:release-1.2 Aug 16, 2024
7 checks passed
@Two-Hearts Two-Hearts deleted the release branch August 16, 2024 03:40
vaninrao10
vaninrao10 reviewed Aug 19, 2024
View reviewed changes
Copy link
Contributor

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the OCI is removed in the inspect.md for the artifacts, but in policy .md we have retained the OCI artifact, dont we think there is a mismatch here "of signature verification workflow of signed OCI artifacts" ? Will it confuse the reader.

@Two-Hearts Two-Hearts mentioned this pull request Aug 20, 2024
Merged
7 tasks
Two-Hearts added a commit to Two-Hearts/notation that referenced this pull request Sep 26, 2024
@Two-Hearts
refactor!: remove blob sign/verify related contents (notaryproject#1011)
3d40f67 
Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts added a commit to Two-Hearts/notation that referenced this pull request Oct 8, 2024
@Two-Hearts
refactor!: remove blob sign/verify related contents (notaryproject#1011)
afa9335 
Signed-off-by: Patrick Zheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaninrao10 vaninrao10 vaninrao10 left review comments

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Two-Hearts @priteshbandi @shizhMSFT @JeyJeyGao @vaninrao10